Week 7 - Simplying Needs & Saving a Path

Simpler Needs

Last week, the need-based behaviors pull request was created. This quickly grew into the largest pull request of the project, with almost 1500 additional lines. This became very hard to manage & review (sorry mentors), so I had to shorten it down/generally make the code look better. This was accomplished in two different ways:
  • For all needs, there was a different target action & fulfillment action for each. I changed the code to merge these common sections together into common target selection & need fulfillment actions; greatly reducing the complexity and size of the pull request.
  • The need based pull request was technically in two parts; the addition of new characters, and the addition of the need-based behaviors. I made a second pull request and separated these two pieces to be reviewed in two different spots. This cut about 500 lines from the pull request alone.
With these two changes, the need-based behaviors pull request is finally ready for review & merging!

On the right path

Last week, a problem with saving a path to a component was discovered. This week, the cause of this issue was discovered, and it's all down to exactly how a component is saved to an entity. To save a component, all of its internal fields are copied & placed on an identical component. The serialization system uses a variety of copy strategies to pull this off. The 'Path' field was made extending ArrayList, so the serialization system used the "ListCopyStrategy" class. This class assumes that any list can be saved as an ArrayList. So when a Path is saved, it is converted internally to this form. However, when the copied 'Path' is saved back to the component, the system fails, since the converted array list is different from a pure path.
This is a very complex serialization issue (and one that took many hours to determine). This can be solved by either changing 'Path' is some way, or by changing 'ListCopyStrategy in some way; this will be determined in the weekly meeting.

Over the Next Week

  • From the solution determined in this weeks meeting, fix the Path serialization error.
  • Writing a detailed module description for the readme file, to be displayed on Github.
  • When these items are done, starting development on factions!

PRs & Issues

Comments

Post a Comment

Popular posts from this blog

GSOC 2019 Final Report

Image
Summary After more than 12 weeks of development, it is time to close this summer of code 2019 project! Over 30 total pull requests have been made over the course of the project, with 58 commits & approximately 8000 lines of code added to the Metal Renegades repository alone! It has been an incredibly busy few months. This project involved taking a new gameplay module proposal posted on the forum  here , and implement the technical backbone of the world, so that the core gameplay can be built on top of it. This ended up primarily consisting of AI characters, but also included other aspects, such as player needs, and getting rid of some underlying technical issues. This repository has been worked on in collaboration with Wabadump in their GSOC project. We both happened to make proposals in the same area, so we cut out as much overlap as possible & both worked on different sections of the module. In some areas the proposal tasks were slightly altered due to it alre...
Read more

GSOC 2020 Final Report

Image
Summary At the end of 12 weeks of development, my GSOC 2020 project Metal Renegades: Refining Gameplay is finally complete. Over the course of this summer, over 40 pull requests have been made against 13 different modules in Terasology. These merged pull requests together contain more than 5000 line changes. The original goal of this project was to improve the gameplay of the Metal Renegades module based on top of the technical backbone work done last year. This goal was achieved over the summer by adding new gameplay features to the module, refining already existing features, and fixing bugs that negatively impact the core experience. Major Project Achievements City Water Wells Last year, thirst was added to the module. If the player doesn't keep their thirst bar above zero, they will slowly lose health and eventually die. This thirst was previously fulfilled by using wells inside the city, which would in...
Read more

Week 11 - Engine Changes & City Timesteps

Image
A Change to Serialization & Health This week two major changes have occured in the Terasology codebase. In the engine, a new serialization system was merged into master, which reads and writes all the assets & save files more efficiently. The number of changes in the serialization pull request.... oh my! This update required many changes to multiple modules in my workspace, which took up more time than expected. If you recall from three weeks ago, I had some troubles with pathfinding serialization, where the game would throw errors when a path is saved to a character. With this new system, the errors have reoccured again.... Except this time, the game doesn't only throw errors, it crashes entirely with a NullPointerException. The current cause of this is unknown, and must be fixed as soon as possible. In addition to this change, vital changes have been made to the Terasology/Health module as part of another GSOC project, which changes the way that events are ...
Read more